Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: inconsistent punctuation in understanding-github-actions.md #20079

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Fix: inconsistent punctuation in understanding-github-actions.md #20079

merged 2 commits into from
Aug 23, 2022

Conversation

ImUnlikely
Copy link
Contributor

@ImUnlikely ImUnlikely commented Aug 23, 2022 •
edited
Loading

Why:

Punctuation like periods come before the ending quotation mark in the US. All other quotation marks in the document use .", this was the only one that placed the period after the closing quotation mark.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Moved period one place left so it comes before the closing quotation mark.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@ImUnlikely
Fix: inconsistent punctuation in understanding-github-actions.md
a9956bd 
Punctuation like periods come **before** the ending quotation mark in the US. All other quotation marks in the document use `."`, this was the only one that placed the period after the closing quotation mark.
@welcome
Copy link

welcome bot commented Aug 23, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/learn-github-actions/understanding-github-actions.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
 fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@ImUnlikely Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 23, 2022
cmwilson21
cmwilson21 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@cmwilson21 cmwilson21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmwilson21
Copy link
Contributor

Thanks for spotting this and offering a fix! I'll get this merged down once the tests have all passed 🍏

@cmwilson21 cmwilson21 added the ready to merge This pull request is ready to merge label Aug 23, 2022
@cmwilson21 cmwilson21 merged commit 6cc202e into github:main Aug 23, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@ImUnlikely ImUnlikely deleted the patch-2 branch November 8, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwilson21 cmwilson21 cmwilson21 approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ImUnlikely @cmwilson21